Transport Handler

aaron02 · 14. September 2015, 16:38

Hello i changed the Transport system to allow Transporters in Instances and Stop them.
Here is a little showoff:

there are still some problems with the creatures... on some transporters they are working fine and on others they get pushed off the transporter when interacting with them.
i will upload a patch if it maybe someone else nows how to fix the creature problem.

Zyres · 14. September 2015, 17:52

Looks very nice.

transport creatures needs the missing spawn flags to work correctly (we should add these flags to table transport_creatures like event_creature_spawns?).

aaron02 · 14. Oktober 2015, 22:02

Hello

i finished some work on the transporter system
there are new commands :

.transporter spawn
stop
start
despawn
modperiod

but there are bugs and i dont find a soloution to fix these:

first problem is that the transporters are working but the calculation of move to next waypoint is wrong or something like that that means the transporer is desyncronized and we get teleporter at a wrong point and the transporter is messed up .
transporters in instances are working.
creatures on transporters are working you can interact with them and they stay on the transporter

maybe evafairy or dankodj knows a way to fix it.

feel free to use this i would like to see it fully fixed.
when i find a soloution to fix it i will update the patch.

greetings aaron

DankoDJ · 15. Oktober 2015, 10:25

Hi aaron02

Thank you for yiur contribution. I can't test this patch:
- Worldserver crash immediately on transport arrival

Make sure you created patches based on a clean copy of our current master. Something is weird inside this patch for example these diffs:

dep/bzip2/manual.html | 15 +
dep/dll/libeay32.dll | Bin 1011712 -> 1069568 bytes
dep/dll/libmySQL.dll | Bin 2121728 -> 2183168 bytes

regards

aaron02 · 15. Oktober 2015, 11:08

Thank you it was a clean coppy i try it agsin and upload a new one

Edit.
Tested again with this oatch not crashing for me

i look at it atfter work

DankoDJ · 15. Oktober 2015, 17:12

Check out:
github.com/AscEmu/AscEmu/commi…57539bff13e92862f4ad0e126
github.com/AscEmu/AscEmu/commi…10dcf7e9ad8c14e3bf3715280
on branch:
github.com/AscEmu/AscEmu/tree/feature/transporter

first problem is that the transporters are working but the calculation of move to next waypoint is wrong or something like that that means the transporer is desyncronized and we get teleporter at a wrong point and the transporter is messed up .

This is now solved.

1. Debug compilation is broken, check out the crash report. (ASSERT on unit create->mapmgr)
2. If you try to talk to some npcs they run away to another position.
3. Why do you use a new table?
4. sota should be updated too, I commented two lines to investigate your problem.
5. The worldserver is crashing after a while (it is nearly impossible to check this without debug compilation)

regards

aaron02 · 15. Oktober 2015, 18:39

i will look at it i.

on sota its not used its okay the transporters there are like elevators they need to be added. ist nothing with the transport handler.
after compiling on debug mode and startup in debug i got no crash.
i used a new table because they are creatures to keep them near the other creature stuff

i keep the server online in debug mode for the night i look tommorow for a call stack

fixed creature problem i make a PR

Zyres · 15. Oktober 2015, 21:45

DankoDJ schrieb:

1. Debug compilation is broken, check out the crash report. (ASSERT on unit create->mapmgr)
2. If you try to talk to some npcs they run away to another position.
3. Why do you use a new table?
4. sota should be updated too, I commented two lines to investigate your problem.
5. The worldserver is crashing after a while (it is nearly impossible to check this without debug compilation)

1. works
2. clientside/spline packet (relog your char and everything is fine)
3. What should happen to the old table? It is useless now.
4. not a part of aaron02 work (we should rewrite it later)
5. Nothing happen after 3 hours...

aaron02 · 15. Oktober 2015, 22:03

on sota you need to spawn
Boat one alliance = 193182
Boat two Horde = 193183
Boat one Horde = 193184
Boat two alliance = 193185

then stop them until battle is ready then start movement and stop at the beach

Zyres · 15. Oktober 2015, 23:21

5. Nothing happen after 3 hours...

Travel from Durotar -> Warsong Hold, leave the transporter and wait... the transporter travels back to Durotar. If it's traveling back to Warsong Hold server crashes.
i.imgur.com/Mb5Jt2q.jpg

Using: github.com/AscEmu/AscEmu/tree/feature/transporter

aaron02 · 16. Oktober 2015, 06:53

uptime 5 houers with my new pull request. tried to reproduce your crash not happening.

github.com/AscEmu/AscEmu/pull/150

Tulba · 16. Oktober 2015, 09:26

Here you go. (Sorry for jumping around XD)

aaron02 · 16. Oktober 2015, 10:03

The missing creatures is wrong filing of the spline movement i think
The doublespawns are need to be deleted from rhe creature spawns table

Tulba · 16. Oktober 2015, 10:41

The double spawn is not the problem... The server is crashing trying to port the npc-passenger on changing the map, they falling through the map. (5min 20sec).

Travel from Durotar -> Warsong Hold, leave the transporter and wait... the transporter travels back to Durotar. If it's traveling back to Warsong Hold server crashes.

So this is valid for intercontinental transporters.

Using lates feature/transporter (includ your PR) Debug Win32 with all modules.

aaron02 · 16. Oktober 2015, 23:58

i reproduced this and i get thos errors too.
and crash because m_session account flags ... for me i need to look at this i dont know why its doing this

maybe some wrong positions

Zyres · 5. November 2015, 21:20

Some news for this problem

Using current feature/transporter branch.
Everything is like the youtube video. Here is the Call Stack:
[IMG:http://i.imgur.com/glwPewN.jpg]

Sometimes while debugging:
[IMG:http://i.imgur.com/XmqXUrC.jpg]

Zyres · 13. Februar 2016, 14:22

Finally we have fixed the issues.
If you want to see this in master, follow these points:
- Pull github.com/AscEmu/AscEmu/tree/feature/transporter
- Setup AscEmu
- apply the sql-file sql/world_updates/new_transport_creatures.sql

We need feedback! Test the transporters and if you think everything looks good or there are NEW issues, give us the feedback.

Features:
- transport creatures can talk (creature-scripts are loaded)
- transport creatures didn't disappear
- players can logout on transporter (they will be added to the transporter on login)
- players didn't fall through the transporter

ToDos after transporter branch is merged into develop:
- update world_db_version
- Remove transporter creatures (doublespawns) from creature_spawns
- Update creature_name/proto (some vendors has the wrong flag)
- Add the unit flag to transport_creatures table (vendors need this)

Tulba · 13. Februar 2016, 14:55

I will retest it as soon as possible

Tulba · 15. Februar 2016, 13:44

==UPDATE==
Awesome - I tested it during the last two days (open world transports). No crashes, creatures didn't disappear anymore. Thanks to all authors, great work!

Teilen