[TALENT-FIX]Mage - Firestarter

    Diese Seite verwendet Cookies. Durch die Nutzung unserer Seite erklären Sie sich damit einverstanden, dass wir Cookies setzen. Weitere Informationen

    • [TALENT-FIX]Mage - Firestarter

      This post is to fix the issue #306 on the tracker. I've tested this fix and it works

      How does the spell/aura currently work ingame with the current commit of AscEmu?
      It procs on any damaging spell which is incorrect, I see no procs in the database or hackfixes or spell_classscripts, so im assuming that it is hardcoded (which I have overrided)

      How does the submitted fix for the spell/aura work and are there still any issues?
      It fixes the talent, it now only procs on Dragon's Breath or Blast Wave and the aura is correctly removed from the player after casting flamestrike. There are no other issues after fixing this the talent works blizzlike now.

      If you have any other questions please ask. You will need to add the Hackfixes pastebin to the mage section and the Spell_ClassScripts pastebin to the mage section of that as well.

      Hackfixes.cpp Pastebin (This includes procs i don't know how to add it via database since that part is new??)

      Spell_ClassScripts.cpp Pastebin (This includes the removal of the aura after casting flamestrike.)
    • C-Quellcode

      1. //Mage - firestarter talent ranks 1 & 2
      2. // we are overriding the current wrong procs, should only proc on these 2 spells.
      3. sp = CheckAndReturnSpellEntry(44442);
      4. if (sp != NULL)
      5. {
      6. sp->procFlags = PROC_ON_CAST_SPELL;
      7. sp->procChance = 50;
      8. sp->custom_ProcOnNameHash[0] = SPELL_HASH_DRAGON_S_BREATH;
      9. sp->custom_ProcOnNameHash[1] = SPELL_HASH_BLAST_WAVE;
      10. }
      11. sp = CheckAndReturnSpellEntry(44443);
      12. if (sp != NULL)
      13. {
      14. sp->procFlags = PROC_ON_CAST_SPELL;
      15. sp->custom_ProcOnNameHash[0] = SPELL_HASH_DRAGON_S_BREATH;
      16. sp->custom_ProcOnNameHash[1] = SPELL_HASH_BLAST_WAVE;
      17. }
      Alles anzeigen
      Can you please use our board functions instead of pastebin for these small code submissions?

      If you don't know how to add it via database, maybe you should check out the wiki... just saying... ascemu.org/wiki/index.php?title=WorldDB

      To add namehash fixes looks a bit off... as you can see in the latest news, we try to get rid of this invalid workaround...
    • Zyres schrieb:

      C-Quellcode

      1. //Mage - firestarter talent ranks 1 & 2
      2. // we are overriding the current wrong procs, should only proc on these 2 spells.
      3. sp = CheckAndReturnSpellEntry(44442);
      4. if (sp != NULL)
      5. {
      6. sp->procFlags = PROC_ON_CAST_SPELL;
      7. sp->procChance = 50;
      8. sp->custom_ProcOnNameHash[0] = SPELL_HASH_DRAGON_S_BREATH;
      9. sp->custom_ProcOnNameHash[1] = SPELL_HASH_BLAST_WAVE;
      10. }
      11. sp = CheckAndReturnSpellEntry(44443);
      12. if (sp != NULL)
      13. {
      14. sp->procFlags = PROC_ON_CAST_SPELL;
      15. sp->custom_ProcOnNameHash[0] = SPELL_HASH_DRAGON_S_BREATH;
      16. sp->custom_ProcOnNameHash[1] = SPELL_HASH_BLAST_WAVE;
      17. }
      Alles anzeigen
      Can you please use our board functions instead of pastebin for these small code submissions?

      If you don't know how to add it via database, maybe you should check out the wiki... just saying... ascemu.org/wiki/index.php?title=WorldDB

      To add namehash fixes looks a bit off... as you can see in the latest news, we try to get rid of this invalid workaround...
      Alrighty will do. Will do from now on, thanks for the wiki link forgot about that actually.